From 17e5c6c1724c0fec63a8ded49d56e3edba0a2c28 Mon Sep 17 00:00:00 2001
From: hacksalot <hacksalot@indevious.com>
Date: Fri, 9 Feb 2018 00:17:10 -0500
Subject: [PATCH] style: notate an issue in skills coalescing func

---
 dist/core/fresh-resume.js    |  4 +++-
 src/core/fresh-resume.coffee | 19 ++++++++++++++++++-
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/dist/core/fresh-resume.js b/dist/core/fresh-resume.js
index 344c421..5546a41 100644
--- a/dist/core/fresh-resume.js
+++ b/dist/core/fresh-resume.js
@@ -213,7 +213,9 @@ Definition of the FRESHResume class.
     };
 
 
-    /** Return a unique list of all keywords across all skills. */
+    /**
+    Return a unique list of all skills declared in the resume.
+     */
 
     FreshResume.prototype.keywords = function() {
       var flatSkills;
diff --git a/src/core/fresh-resume.coffee b/src/core/fresh-resume.coffee
index f24a073..a17d9fd 100644
--- a/src/core/fresh-resume.coffee
+++ b/src/core/fresh-resume.coffee
@@ -180,7 +180,24 @@ class FreshResume# extends AbstractResume
 
 
 
-  ###* Return a unique list of all keywords across all skills. ###
+  ###*
+  Return a unique list of all skills declared in the resume.
+  ###
+
+  # TODO: Several problems here:
+  # 1) Confusing name. Easily confused with the keyword-inspector module, which
+  # parses resume body text looking for these same keywords. This should probably
+  # be renamed.
+  #
+  # 2) Doesn't bother trying to integrate skills.list with skills.sets if they
+  # happen to declare different skills, and if skills.sets declares ONE skill and
+  # skills.list declared 50, only 1 skill will be registered.
+  #
+  # 3) In the future, skill.sets should only be able to use skills declared in
+  # skills.list. That is, skills.list is the official record of a candidate's
+  # declared skills. skills.sets is just a way of grouping those into skillsets
+  # for easier consumption.
+
   keywords: () ->
     flatSkills = []
     if @skills