1
0
mirror of https://github.com/JuanCanham/HackMyResume.git synced 2024-11-05 09:56:22 +00:00

Move string transformation out of FRESHResume.

This commit is contained in:
hacksalot 2016-01-12 13:28:20 -05:00
parent 8ced6a730a
commit 1966b0a862
2 changed files with 68 additions and 38 deletions

View File

@ -62,6 +62,7 @@ Definition of the FRESHResume class.
consistent format. Then sort each section by startDate descending. consistent format. Then sort each section by startDate descending.
*/ */
FreshResume.prototype.parseJSON = function( rep, opts ) { FreshResume.prototype.parseJSON = function( rep, opts ) {
// Convert JSON Resume to FRESH if necessary // Convert JSON Resume to FRESH if necessary
if( rep.basics ) { if( rep.basics ) {
rep = CONVERTER.toFRESH( rep ); rep = CONVERTER.toFRESH( rep );
@ -161,45 +162,9 @@ Definition of the FRESHResume class.
a transformation function (such as a Markdown filter or XML encoder). a transformation function (such as a Markdown filter or XML encoder).
*/ */
FreshResume.prototype.transformStrings = function( filt, transformer ) { FreshResume.prototype.transformStrings = function( filt, transformer ) {
var that = this;
var ret = this.dupe(); var ret = this.dupe();
var trx = require('../utils/string-transformer');
// TODO: refactor recursion return trx( ret, filt, transformer );
function transformStringsInObject( obj, filters ) {
if( !obj ) return;
if( moment.isMoment( obj ) ) return;
if( _.isArray( obj ) ) {
obj.forEach( function(elem, idx, ar) {
if( typeof elem === 'string' || elem instanceof String )
ar[idx] = transformer( null, elem );
else if (_.isObject(elem))
transformStringsInObject( elem, filters );
});
}
else if (_.isObject( obj )) {
Object.keys( obj ).forEach(function(k) {
if( filters.length && _.contains(filters, k) )
return;
var sub = obj[k];
if( typeof sub === 'string' || sub instanceof String ) {
obj[k] = transformer( k, sub );
}
else if (_.isObject( sub ))
transformStringsInObject( sub, filters );
});
}
}
Object.keys( ret ).forEach(function(member){
if( !filt || !filt.length || !_.contains(filt, member) )
transformStringsInObject( ret[ member ], filt || [] );
});
return ret;
}; };

View File

@ -0,0 +1,65 @@
/**
Object string transformation.
@module string-transformer.js
@license MIT. See LICENSE.md for details.
*/
(function() {
var _ = require('underscore');
var moment = require('moment');
/**
Create a copy of this object in which all string fields have been run through
a transformation function (such as a Markdown filter or XML encoder).
*/
module.exports = function( ret, filt, transformer ) {
var that = this;
// TODO: refactor recursion
function transformStringsInObject( obj, filters ) {
if( !obj ) return;
if( moment.isMoment( obj ) ) return;
if( _.isArray( obj ) ) {
obj.forEach( function(elem, idx, ar) {
if( typeof elem === 'string' || elem instanceof String )
ar[idx] = transformer( null, elem );
else if (_.isObject(elem))
transformStringsInObject( elem, filters );
});
}
else if (_.isObject( obj )) {
Object.keys( obj ).forEach(function(k) {
if( filters.length && _.contains(filters, k) )
return;
var sub = obj[k];
if( typeof sub === 'string' || sub instanceof String ) {
obj[k] = transformer( k, sub );
}
else if (_.isObject( sub ))
transformStringsInObject( sub, filters );
});
}
}
Object.keys( ret ).forEach(function(member){
if( !filt || !filt.length || !_.contains(filt, member) )
transformStringsInObject( ret[ member ], filt || [] );
});
return ret;
};
}());