JuanCanham/HackMyResume
1
0
Fork 0
mirror of https://github.com/JuanCanham/HackMyResume.git synced 2025-11-03 22:37:27 +00:00
Code Issues Releases Wiki Activity

Fix string iteration filtering glitch.

Browse Source
This commit is contained in:
hacksalot
2016-01-03 07:35:47 -05:00
parent 46c7fa9838
commit 247eec396c
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/core/fresh-resume.js
View File

@@ -86,13 +86,13 @@ Definition of the FRESHResume class.
Create a copy of this resume in which all string fields have been run through Create a copy of this resume in which all string fields have been run through
a transformation function (such as a Markdown filter or XML encoder). a transformation function (such as a Markdown filter or XML encoder).
*/ */
FreshResume.prototype.transformStrings = function( filters, transformer ) { FreshResume.prototype.transformStrings = function( filt, transformer ) {
var that = this; var that = this;
var ret = this.dupe(); var ret = this.dupe();
// TODO: refactor recursion // TODO: refactor recursion
function transformStringsInObject( obj ) { function transformStringsInObject( obj, filters ) {
if( !obj ) return; if( !obj ) return;
if( moment.isMoment( obj ) ) return; if( moment.isMoment( obj ) ) return;
@@ -102,26 +102,27 @@ Definition of the FRESHResume class.
if( typeof elem === 'string' || elem instanceof String ) if( typeof elem === 'string' || elem instanceof String )
ar[idx] = transformer( null, elem ); ar[idx] = transformer( null, elem );
else if (_.isObject(elem)) else if (_.isObject(elem))
transformStringsInObject( elem ); transformStringsInObject( elem, filters );
}); });
} }
else if (_.isObject( obj )) { else if (_.isObject( obj )) {
Object.keys( obj ).forEach(function(k) { Object.keys( obj ).forEach(function(k) {
if( filters.length && _.contains(filters, k) )
return;
var sub = obj[k]; var sub = obj[k];
if( typeof sub === 'string' || sub instanceof String ) { if( typeof sub === 'string' || sub instanceof String ) {
if( filters.length && _.contains(filters, k) )
return;
obj[k] = transformer( k, sub ); obj[k] = transformer( k, sub );
} }
else if (_.isObject( sub )) else if (_.isObject( sub ))
transformStringsInObject( sub ); transformStringsInObject( sub, filters );
}); });
} }
} }
Object.keys( ret ).forEach(function(member){ Object.keys( ret ).forEach(function(member){
transformStringsInObject( ret[ member ] ); if( !filt || !filt.length || !_.contains(filt, member) )
transformStringsInObject( ret[ member ], filt || [] );
}); });
return ret; return ret;