JuanCanham/HackMyResume
1
0
Fork 0
mirror of https://github.com/JuanCanham/HackMyResume.git synced 2024-11-24 17:30:10 +00:00
Code Issues Releases Wiki Activity

[fix] Private fields: Resolve off-by-one error.

Browse Source
This commit is contained in:
hacksalot 2018-01-31 00:10:37 -05:00
parent 7f7c936897
commit c6adab7f9e
No known key found for this signature in database
GPG Key ID: 2F343EC247CA4B06
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dist/core/abstract-resume.js vendored
View File

@ -83,10 +83,10 @@ Definition of the AbstractResume class.
if (!this.isLeaf) { if (!this.isLeaf) {
if (this.node.ignore === true || this.node.ignore === 'true') { if (this.node.ignore === true || this.node.ignore === 'true') {
ignoreList.push(this.node); ignoreList.push(this.node);
return this.remove(); this["delete"]();
} else if ((this.node["private"] === true || this.node["private"] === 'true') && !includePrivates) { } else if ((this.node["private"] === true || this.node["private"] === 'true') && !includePrivates) {
privateList.push(this.node); privateList.push(this.node);
return this.remove(); this["delete"]();
} }
} }
}); });

5
src/core/abstract-resume.coffee
View File

@ -69,10 +69,11 @@ class AbstractResume
if !@isLeaf if !@isLeaf
if @node.ignore == true || @node.ignore == 'true' if @node.ignore == true || @node.ignore == 'true'
ignoreList.push @node ignoreList.push @node
@remove() @delete()
else if (@node.private == true || @node.private == 'true') && !includePrivates else if (@node.private == true || @node.private == 'true') && !includePrivates
privateList.push @node privateList.push @node
@remove() @delete()
return
scrubbed: scrubbed scrubbed: scrubbed
ingoreList: ignoreList ingoreList: ignoreList