JuanCanham/HackMyResume
1
0
Fork 0
mirror of https://github.com/JuanCanham/HackMyResume.git synced 2025-05-10 07:47:07 +01:00
Code Issues Releases Wiki Activity

style: notate an issue in skills coalescing func

Browse Source
This commit is contained in:
hacksalot
2018-02-09 00:17:10 -05:00
parent ea3c72845e
commit 17e5c6c172
2 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/core/fresh-resume.coffee
View File

@ -180,7 +180,24 @@ class FreshResume# extends AbstractResume
###* Return a unique list of all keywords across all skills. ###
###*
Return a unique list of all skills declared in the resume.
###
# TODO: Several problems here:
# 1) Confusing name. Easily confused with the keyword-inspector module, which
# parses resume body text looking for these same keywords. This should probably
# be renamed.
#
# 2) Doesn't bother trying to integrate skills.list with skills.sets if they
# happen to declare different skills, and if skills.sets declares ONE skill and
# skills.list declared 50, only 1 skill will be registered.
#
# 3) In the future, skill.sets should only be able to use skills declared in
# skills.list. That is, skills.list is the official record of a candidate's
# declared skills. skills.sets is just a way of grouping those into skillsets
# for easier consumption.
keywords: () ->
flatSkills = []
if @skills